On 28.08.19 08:38, Weijie Gao wrote:
This patch adds a referenceable name to eth node, and adds default pinctrl for all boards.
There are two pinctrl nodes used for two scenarios: ephy_iot_mode - for IOT boards which have only one port (PHY0) ephy_router_mode - For routers which have more than one ports
Signed-off-by: Weijie Gao weijie.gao@mediatek.com
Again my comment about staying in sync with the Linux DT bindings. It might be that case, that Linux is still missing some defines for the pinctrl (like this IOT one).
Reviewed-by: Stefan Roese sr@denx.de
Thanks, Stefan
arch/mips/dts/gardena-smart-gateway-mt7688.dts | 5 +++++ arch/mips/dts/linkit-smart-7688.dts | 5 +++++ arch/mips/dts/mt7628a.dtsi | 2 +- 3 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/arch/mips/dts/gardena-smart-gateway-mt7688.dts b/arch/mips/dts/gardena-smart-gateway-mt7688.dts index 8a9b8227b7..1a2629ad9d 100644 --- a/arch/mips/dts/gardena-smart-gateway-mt7688.dts +++ b/arch/mips/dts/gardena-smart-gateway-mt7688.dts @@ -121,3 +121,8 @@ reg = <1>; }; };
+ð {
- pinctrl-names = "default";
- pinctrl-0 = <&ephy_iot_mode>;
+}; diff --git a/arch/mips/dts/linkit-smart-7688.dts b/arch/mips/dts/linkit-smart-7688.dts index 7dbd909d00..aca1ec8c70 100644 --- a/arch/mips/dts/linkit-smart-7688.dts +++ b/arch/mips/dts/linkit-smart-7688.dts @@ -51,3 +51,8 @@ reg = <0>; }; };
+ð {
- pinctrl-names = "default";
- pinctrl-0 = <&ephy_iot_mode>;
+}; diff --git a/arch/mips/dts/mt7628a.dtsi b/arch/mips/dts/mt7628a.dtsi index 929397c729..f13b539242 100644 --- a/arch/mips/dts/mt7628a.dtsi +++ b/arch/mips/dts/mt7628a.dtsi @@ -352,7 +352,7 @@ }; };
- eth@10110000 {
- eth: eth@10110000 { compatible = "mediatek,mt7628-eth"; reg = <0x10100000 0x10000 0x10110000 0x8000>;
Viele Grüße, Stefan