Re: [PATCH v2 06/11] net: dwc_eth_qos: Move log_debug statements on top of case block

On 3/26/24 13:07, Marek Vasut wrote:

Move the log_debug() calls on top of the bit manipulation code. No functional change.

Reviewed-by: Patrice Chotard patrice.chotard@foss.st.com Signed-off-by: Marek Vasut marex@denx.de

---

Cc: Christophe Roullier christophe.roullier@st.com Cc: Joe Hershberger joe.hershberger@ni.com Cc: Patrice Chotard patrice.chotard@foss.st.com Cc: Patrick Delaunay patrick.delaunay@foss.st.com Cc: Ramon Fried rfried.dev@gmail.com Cc: u-boot@dh-electronics.com Cc: uboot-stm32@st-md-mailman.stormreply.com

---

V2: Add RB from Patrice

drivers/net/dwc_eth_qos_stm32.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/dwc_eth_qos_stm32.c b/drivers/net/dwc_eth_qos_stm32.c index 7545026b158..38037c47954 100644 --- a/drivers/net/dwc_eth_qos_stm32.c +++ b/drivers/net/dwc_eth_qos_stm32.c @@ -143,34 +143,34 @@ static int eqos_probe_syscfg_stm32(struct udevice *dev,

switch (interface_type) { case PHY_INTERFACE_MODE_MII:

• log_debug("PHY_INTERFACE_MODE_MII\n");
  

  value = FIELD_PREP(SYSCFG_PMCSETR_ETH_SEL_MASK, SYSCFG_PMCSETR_ETH_SEL_GMII_MII); value |= SYSCFG_PMCSETR_ETH_REF_CLK_SEL;

• log_debug("PHY_INTERFACE_MODE_MII\n");
  

  break; case PHY_INTERFACE_MODE_GMII:

• log_debug("PHY_INTERFACE_MODE_GMII\n");
  

  value = FIELD_PREP(SYSCFG_PMCSETR_ETH_SEL_MASK, SYSCFG_PMCSETR_ETH_SEL_GMII_MII); if (eth_clk_sel_reg) value |= SYSCFG_PMCSETR_ETH_CLK_SEL;

• log_debug("PHY_INTERFACE_MODE_GMII\n");
  

  break; case PHY_INTERFACE_MODE_RMII:

• log_debug("PHY_INTERFACE_MODE_RMII\n");
  

  value = FIELD_PREP(SYSCFG_PMCSETR_ETH_SEL_MASK, SYSCFG_PMCSETR_ETH_SEL_RMII); if (eth_ref_clk_sel_reg) value |= SYSCFG_PMCSETR_ETH_REF_CLK_SEL;

• log_debug("PHY_INTERFACE_MODE_RMII\n");
  

  break; case PHY_INTERFACE_MODE_RGMII: case PHY_INTERFACE_MODE_RGMII_ID: case PHY_INTERFACE_MODE_RGMII_RXID: case PHY_INTERFACE_MODE_RGMII_TXID:

• log_debug("PHY_INTERFACE_MODE_RGMII\n");
  

  value = FIELD_PREP(SYSCFG_PMCSETR_ETH_SEL_MASK, SYSCFG_PMCSETR_ETH_SEL_RGMII); if (eth_clk_sel_reg) value |= SYSCFG_PMCSETR_ETH_CLK_SEL;

• log_debug("PHY_INTERFACE_MODE_RGMII\n");
  

  break; default: log_debug("Do not manage %d interface\n",

Applied on u-boot-stm32/master