Dear Marek Vasut,
In message 200907021200.03012.marek.vasut@gmail.com you wrote: ...
Patch is included in this mail. Do you also need S-O-B line?
Please make sure to read the documentation before posting, for example http://www.denx.de/wiki/U-Boot/Patches
Makefile | 3 + board/palmtc/Makefile | 54 ++++++ board/palmtc/config.mk | 3 + board/palmtc/lowlevel_init.S | 435 ++++++++++++++++++++++++++++++++++++++> ++++ board/palmtc/palmtc.c | 72 +++++++ board/palmtc/u-boot.lds | 56 ++++++ cpu/pxa/pxafb.c | 34 ++++ include/configs/palmtc.h | 238 +++++++++++++++++++++++ 8 files changed, 895 insertions(+), 0 deletions(-) create mode 100644 board/palmtc/Makefile create mode 100644 board/palmtc/config.mk create mode 100644 board/palmtc/lowlevel_init.S create mode 100644 board/palmtc/palmtc.c create mode 100644 board/palmtc/u-boot.lds create mode 100644 include/configs/palmtc.h
Entries to MAINTAINERS and MAKEALL (ands eventually to README) missing.
diff --git a/Makefile b/Makefile index 24e6410..3fdb1c9 100644 --- a/Makefile +++ b/Makefile @@ -3041,6 +3041,9 @@ scpu_config: unconfig pxa255_idp_config: unconfig @$(MKCONFIG) $(@:_config=) arm pxa pxa255_idp
+palmtc_config: unconfig
- @$(MKCONFIG) $(@:_config=) arm pxa palmtc
Please keep lists sorted.
trizepsiv_config : unconfig @$(MKCONFIG) $(@:_config=) arm pxa trizepsiv
diff --git a/board/palmtc/Makefile b/board/palmtc/Makefile new file mode 100644 index 0000000..92e5288 --- /dev/null +++ b/board/palmtc/Makefile @@ -0,0 +1,54 @@
Delete this empty line.
+# +# Copyright (C) 2009 +# Marek Vasut marek.vasut@gmail.com
...
diff --git a/board/palmtc/config.mk b/board/palmtc/config.mk new file mode 100644 index 0000000..bcb42e7 --- /dev/null +++ b/board/palmtc/config.mk @@ -0,0 +1,3 @@ +#TEXT_BASE = 0xa1700000 +TEXT_BASE = 0xa1000000 +#TEXT_BASE = 0
Please delete dead code.
diff --git a/board/palmtc/lowlevel_init.S b/board/palmtc/lowlevel_init.S new file mode 100644 index 0000000..325bfbd --- /dev/null +++ b/board/palmtc/lowlevel_init.S @@ -0,0 +1,435 @@
...
+/* wait for clock to stabilize */
- .macro CLKWAIT
- ldr r3, =OSCR /* reset the OS Timer Count to zero */
- mov r2, #0
- str r2, [r3]
- ldr r4, =0x300 /* really 0x2E1 is about 200usec, */
/* so 0x300 should be plenty */
Please use TAB instead of spaces for indentation / vertical alignment.
+1:
- ldr r2, [r3]
- cmp r4, r2
- bgt 1b
- .endm
...
- ldr r0, =PSSR /* enable GPIO pins */
- ldr r1, =CONFIG_SYS_PSSR_VAL
- str r1, [r0]
- /* ---------------------------------------------------------------- */
- /* Enable memory interface */
- /* */
Please use TAB instead of spaces for indentation / vertical alignment. [also for rest of file]
Also: incorrecxt multiline comment. Please clean up here and everywhere else.
- /* detailed in the Intel PXA250 Operating Systems Developers Guide, */
- /* Chapter 10. */
- /* ---------------------------------------------------------------- */
...
diff --git a/include/configs/palmtc.h b/include/configs/palmtc.h new file mode 100644 index 0000000..187a165 --- /dev/null +++ b/include/configs/palmtc.h
...
+/*
- High Level Configuration Options
- (easy to change)
- */
+#define CONFIG_PXA250 1 /* This is an PXA250 CPU */ +#define CONFIG_PALMTC 1 /* Palm Tungsten|C board */ +#define BOARD_LATE_INIT 1 +#define CONFIG_BOOT_PALMOS 1 /* Dont disable memory we are running from */
Line too long. Please fix here and everywhere else.
+#define CONFIG_SHOW_BOOT_PROGRESS 1 +#define CONFIG_MMC 1 /* Enable MMC card */ +#define CONFIG_LCD
Please clean up and resubmit.
Best regards,
Wolfgang Denk