On Sunday, September 18, 2011 09:08:35 Graeme Russ wrote:
On 18/09/11 18:22, Mike Frysinger wrote:
On Sunday, September 18, 2011 03:26:38 Wolfgang Denk wrote:
Mike Frysinger wrote:
The top level Makefile does not do any recursion into subdirs when cleaning, so these clean/distclean targets in random arch/board dirs never get used. Punt them all.
I think this is the wrong approach. Would it not be better to get rid of the 60 lines of clean/clobber target in the top level Makefile, including it's brute force methods of "find ... | xargs rm -f" and actually remove the files from the Makefiles in the respective directories instead?
This would for example allow that a board maintainer can fix the clean / clobber rules for his code without having to edit the top level Makefile.
yes & no. i think we should have 1 clean/distclean target, but also have a way for board maintainers to inject their own custom clean files. preferably via a .mk file in their board subdir. this is moving in the direction of non- recursive make like the kernel does -- the top level would source all the subfiles to figure out the master clean list.
however, the current build system has one advantage which i think we should retain in the short term: `make distclean` always cleans out the targets regardless of the current config. for example, if you do `make bf537-stamp` followed by `make harmony` followed by `make distclean`, Blackfin-specific objects will still get cleaned out.
Can we not have make distclean/mrproper traverse ALL arch/SoC/board directories and call their distclean/mrproper? Or have distclean/mrproper read the .mk file for all arch/SoC/board directories?
if it wasn't clear in my last e-mail, i want to move in the direction of .mk files that the top level would include them and thus all the specific cruft would be kept there
after all, the list of things to clean should be obvious once we have more kbuild style system: if it's listed as a file to build, then it should get cleaned. -mike