Hi Lukasz,
Sorry for my late response. Please see my comments inline.
-----Original Message----- From: Lukasz Majewski lukma@denx.de Sent: Friday, August 23, 2019 4:45 PM To: Y.b. Lu yangbo.lu@nxp.com Cc: u-boot@lists.denx.de; Peng Fan peng.fan@nxp.com Subject: Re: [U-Boot] [PATCH 2/3] mmc: fsl_esdhc: clean up code
On Mon, 19 Aug 2019 16:27:49 +0800 Yangbo Lu yangbo.lu@nxp.com wrote:
/* Return the XFERTYP flags for a given command and data packet */ -static uint esdhc_xfertyp(struct mmc_cmd *cmd, struct mmc_data *data) +static uint esdhc_setup_xfertyp(struct mmc_cmd *cmd, struct mmc_data *data) { uint xfertyp = 0;
@@ -310,9 +310,9 @@ static int esdhc_setup_data(struct fsl_esdhc_priv *priv, struct mmc *mmc, return 0; }
-static void check_and_invalidate_dcache_range
- (struct mmc_cmd *cmd,
struct mmc_data *data) {+static void esdhc_invalidate_dcache_range(struct mmc_cmd *cmd,
struct mmc_data *data)^^^^ - it shall be aligned with the (
[Y.b. Lu] Although it's not aligned with the ( in email, it's aligned after applying the patch. I believe there is no issue, and the checkpatch passed before I sent out the patches.
Thanks.
Could you double check this patch set with ./tools/checkpatch.py if it is clean?
(You can also test tools/patman - which does automatic checkpatch check)
+{
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de