On Saturday 15 October 2011 16:27:02 Vadim Bendebury wrote:
On Sat, Oct 15, 2011 at 1:01 PM, Mike Frysinger vapier@gentoo.org wrote:
On Saturday 15 October 2011 15:44:04 Wolfgang Denk wrote:
Vadim Bendebury wrote:
Two underscores aren't a good practice.
I did this as a result of a previous review. Do you have a suggestion how this should be done instead?
First, and most important, __u_boot_cmd_tpm appears to be undefined in your two patches, so it looks to be a real bug.
Second, please read the C standard's section about reserved identifiers.
no, this is coming from common u-boot code. look at include/command.h:U_BOOT_CMD defines.
or, more importantly: the question is what is the right/suggested way to print out the help message associated with a U_BOOT_CMD declaration?
your command is given a cmd_tbl_t *cmdtp pointer to pass to cmd_usage -mike