Hi,
On 9/21/21 8:39 PM, Tom Rini wrote:
On Tue, Sep 21, 2021 at 06:36:03PM +0200, Patrick Delaunay wrote:
Use moveconfig.py script to convert the define CONFIG_ST_SMI to Kconfig and move this entries to defconfigs.
Before migration, the st_smi.c driver was empty when CONFIG_MTD_NOR_FLASH wasn't activated; it is now managed in Kconfig by the "depends on" and this driver is not compiled.
After this patch, the driver st_smic.c is no more used in U-Boot; it was only used in SPEAr products before commit 570c3dcfc153 ("arm: Remove spear600 boards and the rest of SPEAr support").
Signed-off-by: Patrick Delaunay patrick.delaunay@foss.st.com
In the first migration process (without depends on) the config CONFIG_ST_SMI was added in bcm7445_defconfig and bcm7260_defconfig.
But after adding the "depends on MTD_NOR_FLASH" and a Rsync all defconfig files using moveconfig.py the CONFIG_ST_SMI is also deactivated in these 2 last users:
- bcm7260_defconfig
- bcm7445_defconfig
The U-Boot size don't change for these 2 defconfig (tested with buildman).
Thanks for doing a migration. But, since you've found this is dead code now, it would make more sense to just delete the driver.
Sure, I expected this answer when I see that the driver wasn't no more used.
Regards
Patrick