Re: [U-Boot] [PATCH v4 1/4] rtc: ds3232/ds3231: Add support to generate 32KHz output for driver module

Dear Chuanhua Han,

In message 20190726112403.32842-1-chuanhua.han@nxp.com you wrote:

This patch add an implementation of the rtc_enable_32khz_output() that uses the driver model i2c APIs.

...

• ret = i2c_get_chip_for_busnum(busnum, chip_addr, 1, &dev);
• if (!ret)

• ret = dm_i2c_reg_write(dev, RTC_STAT_REG_ADDR,
  

• 		       RTC_STAT_BIT_BB32KHZ |
  

• 		       RTC_STAT_BIT_EN32KHZ);
  

Strictly speaking, this is a multi-line statement following the "if" so braces are required according to the coding style:

if (!ret) { ret = dm_i2c_reg_write(dev, RTC_STAT_REG_ADDR, RTC_STAT_BIT_BB32KHZ | RTC_STAT_BIT_EN32KHZ); }

Best regards,

Wolfgang Denk