Re: [U-Boot] [PATCH 01/14] mmc: s5p: set SD detection pin as input

Hi, Przemyslaw.

On 10/25/2014 12:44 AM, Przemyslaw Marczak wrote:

The SD Card slot detection pin should be configured as input.

Signed-off-by: Przemyslaw Marczak p.marczak@samsung.com

drivers/mmc/s5p_sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c index 0dea45d..a5d3487 100644 --- a/drivers/mmc/s5p_sdhci.c +++ b/drivers/mmc/s5p_sdhci.c @@ -123,7 +123,7 @@ static int do_sdhci_init(struct sdhci_host *host) if (fdt_gpio_isvalid(&host->cd_gpio)) { sprintf(str, "sdhci%d_cd", host->index & 0xf); gpio_request(host->cd_gpio.gpio, str);

• gpio_direction_output(host->cd_gpio.gpio, 1);
  

• gpio_direction_input(host->cd_gpio.gpio);
  

Input is right?

Best Regards, Jaehoon Chung

if (gpio_get_value(host->cd_gpio.gpio))
	return -ENODEV;