Re: [U-Boot] [PATCH] ubi: help message correction

Dear Andrzej Wolski,

In message h3bhhv$l6g$1@ger.gmane.org you wrote:

Fix incorrect information about size units.

Signed-off-by: Andrzej Wolski awolski@poczta.fm

diff --git a/common/cmd_ubi.c b/common/cmd_ubi.c index bbca389..d1653b1 100644 --- a/common/cmd_ubi.c +++ b/common/cmd_ubi.c @@ -608,6 +608,6 @@ U_BOOT_CMD(ubi, 6, 1, do_ubi, " - Remove volume\n" "[Legends]\n" " volume: charater name\n"

• " size: KiB, MiB, GiB, and bytes\n"

• " size: hex value\n" " type: s[tatic] or d[ynamic] (default=dynamic)" );

This is IMHO not a helpful help message.

First, it is reduncant, as all input in U-Boot is in hex format. So why repeat that information. And "size: value" - what does that tell me? Would it not be good to mention the unit? Is it in KiB, MiB, GiB, bytes, blocks, or whatever?

Best regards,

Wolfgang Denk