Re: [U-Boot] [RFC,PATCH v4 14/16] env: fat: support UEFI context

Dear Takahiro,

In message 20190717082525.891-15-takahiro.akashi@linaro.org you wrote:

With this patch, UEFI will be allowed to save/load variables to fat filesystem. The following configurations should be defined.

...

+#if defined(CONFIG_ENV_EFI_FAT_INTERFACE) && \

• defined(CONFIG_ENV_FAT_DEVICE_AND_PART) && \
• defined(CONFIG_ENV_EFI_FAT_FILE)
• [ENVCTX_UEFI] = {

• CONFIG_ENV_EFI_FAT_INTERFACE,
  

• CONFIG_ENV_EFI_FAT_DEVICE_AND_PART,
  

• CONFIG_ENV_EFI_FAT_FILE,
  

• },

+#endif

This looks bad to me, as you will not get any error when one of the defintions is missing.

Best regards,

Wolfgang Denk