Re: [PATCH 02/26] spl: nor: Don't allocate header on stack

On Thu, Oct 12, 2023 at 5:45 AM Simon Glass sjg@chromium.org wrote:

On Wed, 11 Oct 2023 at 18:56, Sean Anderson seanga2@gmail.com wrote:

...

spl_image_info.name contains a reference to legacy_img_hdr. If we allocate the latter on the stack, it will be clobbered after we return. This was addressed for NAND back in 06377c5a1fc ("spl: spl_legacy: Fix NAND boot on OMAP3 BeagleBoard"), but that commit didn't fix NOR.

Signed-off-by: Sean Anderson seanga2@gmail.com

common/spl/spl_nor.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)

Reviewed-by: Simon Glass sjg@chromium.org

Reviewed-by: Michael Trimarchi michael@amarulasolutions.com