-----Original Message----- From: Tom [mailto:Tom.Rix@windriver.com] Sent: Tuesday, December 15, 2009 10:44 PM To: Premi, Sanjeev Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH 0/2] omap3: Optimize detection of cpu revision
Sanjeev Premi wrote:
Each call to get_cpu_rev() leads to repetitive execution of code to detect the cpu revision.
This patchset ensures that mechanism to detect revision is not executed each time; instead a stored value is returned.
Since, revision info is needed in s_init(), the function to identify cpu revision needs to be called twice. At the moment, it is necessary/ unavoidable.
Is there some other reason to read this register only once? This function is not used frequently and i do not think the complexity of optimizing is necessary.
As more processors and revision specific code gets added, there will be more occurrences for this check.
I have just posted patches for basic support for the AM35x processors. Now, the cpurev for this silicon is ES1.0; but have otherwise similar features that the OMAP35x ES3.1 si (I am not accounting other IP differences between the processors here).
Also, I don't believe there is any complexity added as the contents of register are being read and saved in a global variable for use later.
Best regards, Sanjeev
Tom