Wolfgang Denk wrote:
In message 005801c8ccb1$1cd66730$0c0514ac@atmel.com you wrote:
If you want to see changes right now, then just replace the existing file with the Diopsis file and do a diff.
No, this is not the way we work. We submit patches that can be reviewed, not chunks of code that the reviewer has to anayze with additional, unnecessary efforts.
Antonio submits a working patchset which is structured in the same manner as existing boards. Haavard has a different goal which is important, but less urgent than other things.
Why not get the Diopsis support in first, and then do the merge afterwards.
Because this is NOT the way it works. Please stick to the established rules.
Which rule is you referring to?
Since Haavard wants this merge, then I suggest that Haavard takes the existing patches from Antonio and reworks them ASAP, testing them out on AVR32, AT91 and Diopsis, and resubmits the patchset so that we have a working common driver and working AT572D940DF board support.
Haavard, There is an AT572D940HF-EB in Atmel Norway, I gave it to OJ and he should forward it to Haakan. Do you have any AT91 boards?
Best regards,
Wolfgang Denk
Best Regards Ulf Samuelsson ulf@atmel.com Atmel Nordic AB Mail: Box 2033, 174 02 Sundbyberg, Sweden Visit: Kavallerivägen 24, 174 58 Sundbyberg, Sweden Phone +46 (8) 441 54 22 Fax +46 (8) 441 54 29 GSM +46 (706) 22 44 57
Technical support when I am not available: AT90 AVR Applications Group: mailto:avr@atmel.com AT91 ARM Applications Group: mailto:at91support@atmel.com AVR32 Applications Group mailto:avr32@atmel.com http://www.avrfreaks.net/; http://avr32linux.org/ http://www.at91.com/ ; http://www.linux4sam.org/