Re: [PATCH 07/11] pinctrl: single: use function pointer for register access

Hi Dario,

On Sat, 23 Jan 2021 at 11:27, Dario Binacchi dariobin@libero.it wrote:

The patch allows you to call the read/write functions set during probing without having to check the type of access at runtime. It also adds functions for 8-bit registers access.

Signed-off-by: Dario Binacchi dariobin@libero.it

drivers/pinctrl/pinctrl-single.c | 98 ++++++++++++++++++++++++-------- 1 file changed, 73 insertions(+), 25 deletions(-)

I'm not really keen on this. A switch() statement is not expensive and function pointers add indirection/confusion and use more space.

Regards, Simon