Re: [U-Boot] [PATCH v10 1/3] Adding TCP and wget into u-boot

Hi Duncan,

Please change the subject of this patch to: "Prepare to add TCP and wget"

On Sat, Apr 14, 2018 at 6:43 PM, DH@synoia.com wrote:

From: Duncan Hare DuncanCHare@yahoo.com

Include in the body of the log a high-level description, such as: "Consolidating UDP header functions to make it easier to add TCP versions of the same, while reusing the IP portions. This patch should not change any behaviors."

Signed-off-by: Duncan Hare DuncanCHare@yahoo.com

Added a protocol parameter to ip packet sending in net.c Added UDP protocol for current applications to minimize code changes to existing net apps.

All the code is new, and not copied from any source.

Changes in v10: Initial changes for adding TCP

include/net.h | 25 +++++++++++++++++++------ net/net.c | 52 ++++++++++++++++++++++++++++++++++------------------ net/ping.c | 9 ++------- 3 files changed, 55 insertions(+), 31 deletions(-)

diff --git a/include/net.h b/include/net.h index 455b48f6c7..7e5f5a6a5b 100644 --- a/include/net.h +++ b/include/net.h @@ -15,17 +15,26 @@ #include <asm/cache.h> #include <asm/byteorder.h> /* for nton* / ntoh* stuff */

-#define DEBUG_LL_STATE 0 /* Link local state machine changes */ -#define DEBUG_DEV_PKT 0 /* Packets or info directed to the device */ -#define DEBUG_NET_PKT 0 /* Packets on info on the network at large */ +#define DEBUG_LL_STATE 0 /* Link local state machine changes */ +#define DEBUG_DEV_PKT 0 /* Packets or info directed to the device */ +#define DEBUG_NET_PKT 0 /* Packets on info on the network at large */

If you want to do general formatting cleanup, please put it in a separate patch (as patch 1).

#define DEBUG_INT_STATE 0 /* Internal network state changes */

/*

• The number of receive packet buffers, and the required packet buffer
  

• alignment in memory.
  

• • The number of buffers for TCP is used to calculate a static TCP window
    

• • size, becuse TCP window size is a promise to the sending TCP to be able
    

• • to buffer up to the window size of data.
    

• • When the sending TCP has a window size of outstanding unacknowledged
    

• • data, the sending TCP will stop sending.
    

Please add this in the TCP patch.

*/

+#if defined(CONFIG_TCP) +#define CONFIG_SYS_RX_ETH_BUFFER 12 /* For TCP */

That comment is unnecessary... it is obvious from the ifdef surrounding it. Remove the comment.

+#endif

#ifdef CONFIG_SYS_RX_ETH_BUFFER # define PKTBUFSRX CONFIG_SYS_RX_ETH_BUFFER #else @@ -354,6 +363,7 @@ struct vlan_ethernet_hdr {

#define IPPROTO_ICMP 1 /* Internet Control Message Protocol */ #define IPPROTO_UDP 17 /* User Datagram Protocol */ +#define IPPROTO_TCP 6 /* Transmission Control Protocol */

Don't add this define in this patch. Save it for the TCP patch. When you do add it, do so in numerical order.

/*

• Internet Protocol (IP) header.
  

@@ -596,10 +606,10 @@ int net_set_ether(uchar *xet, const uchar *dest_ethaddr, uint prot); int net_update_ether(struct ethernet_hdr *et, uchar *addr, uint prot);

/* Set IP header */ -void net_set_ip_header(uchar *pkt, struct in_addr dest, struct in_addr source); +void net_set_ip_header(uchar *pkt, struct in_addr dest, struct in_addr source,

•                  u16  pkt_len, u8 prot);
  

void net_set_udp_header(uchar *pkt, struct in_addr dest, int dport,

•                           int sport, int len);
  

•                   int sport, int len);
  

This is just a formatting change.

/**

• compute_ip_checksum() - Compute IP checksum

@@ -670,6 +680,9 @@ static inline void net_send_packet(uchar *pkt, int len)

• @param sport Source UDP port
• @param payload_len Length of data after the UDP header

*/ +int net_send_ip_packet(uchar *ether, struct in_addr dest, int dport, int sport,

•                  int payload_len, int proto);
  

Separating with a blank line here and removing it above. Why the inconsistency?

int net_send_udp_packet(uchar *ether, struct in_addr dest, int dport, int sport, int payload_len);

diff --git a/net/net.c b/net/net.c index 4259c9e321..df4e7317e7 100644 --- a/net/net.c +++ b/net/net.c @@ -181,6 +181,7 @@ int net_ntp_time_offset; static uchar net_pkt_buf[(PKTBUFSRX+1) * PKTSIZE_ALIGN + PKTALIGN]; /* Receive packets */ uchar *net_rx_packets[PKTBUFSRX];

Random formatting change.

/* Current UDP RX packet handler */ static rxhand_f *udp_packet_handler; /* Current ARP RX packet handler */ @@ -777,11 +778,23 @@ void net_set_timeout_handler(ulong iv, thand_f *f) }

int net_send_udp_packet(uchar *ether, struct in_addr dest, int dport, int sport,

•           int payload_len)
  

•                   int payload_len)
  

Formatting change.

+{

•   return net_send_ip_packet(ether, dest, dport, sport, payload_len,
  

•                             IPPROTO_UDP);
  

+}

+int net_send_ip_packet(uchar *ether, struct in_addr dest, int dport, int sport,

•                  int payload_len, int proto)
  

Put the declarations and the definitions in the same order (this should be before net_send_udp_packet() ).

{ uchar *pkt; int eth_hdr_size; int pkt_hdr_size;

•   if (proto == IPPROTO_UDP) {
  

•           debug_cond(DEBUG_DEV_PKT,
  

•                      "UDP Send  (to=%pI4, from=%pI4, len=%d)\n",
  

•                      &dest, &net_ip, payload_len);
  

•   }
  
    /* make sure the net_tx_packet is initialized (net_init() was called) */
    assert(net_tx_packet != NULL);
  

@@ -799,9 +812,15 @@ int net_send_udp_packet(uchar *ether, struct in_addr dest, int dport, int sport, pkt = (uchar *)net_tx_packet;

    eth_hdr_size = net_set_ether(pkt, ether, PROT_IP);

•   pkt += eth_hdr_size;
  

•   net_set_udp_header(pkt, dest, dport, sport, payload_len);
  

•   pkt_hdr_size = eth_hdr_size + IP_UDP_HDR_SIZE;
  

•   switch (proto) {
  

•   case IPPROTO_UDP:
  

•           net_set_udp_header(pkt + eth_hdr_size, dest,
  

•                              dport, sport, payload_len);
  

•           pkt_hdr_size = eth_hdr_size + IP_UDP_HDR_SIZE;
  

•   break;
  

•   default:
  

•           return -1;
  

You should return a real -errno... -EINVAL.

•   }
  
    /* if MAC address was not discovered yet, do an ARP request */
    if (memcmp(ether, net_null_ethaddr, 6) == 0) {
  

@@ -1157,9 +1176,6 @@ void net_process_received_packet(uchar *in_packet, int len) /* Can't deal with anything except IPv4 */ if ((ip->ip_hl_v & 0xf0) != 0x40) return;

•           /* Can't deal with IP options (headers != 20 bytes) */
  

•           if ((ip->ip_hl_v & 0x0f) > 0x05)
  

•                   return;
  

This seems like it is more relevant to the TCP patch. What have you added in this patch that changes what headers we can support. This patch is supposed to refactor and not change behavior.

            /* Check the Checksum of the header */
            if (!ip_checksum_ok((uchar *)ip, IP_HDR_SIZE)) {
                    debug("checksum bad\n");

@@ -1205,6 +1221,7 @@ void net_process_received_packet(uchar *in_packet, int len) * we send a tftp packet to a dead connection, or when * there is no server at the other end. */

Random formatting change.

            if (ip->ip_p == IPPROTO_ICMP) {
                    receive_icmp(ip, len, src_ip, et);
                    return;

@@ -1365,8 +1382,7 @@ common: } /**********************************************************************/

-int -net_eth_hdr_size(void) +int net_eth_hdr_size(void)

Random formatting change.

{ ushort myvlanid;

@@ -1426,25 +1442,28 @@ int net_update_ether(struct ethernet_hdr *et, uchar *addr, uint prot) } }

-void net_set_ip_header(uchar *pkt, struct in_addr dest, struct in_addr source) +void net_set_ip_header(uchar *pkt, struct in_addr dest, struct in_addr source,

•                  u16  pkt_len, u8 prot)
  

{ struct ip_udp_hdr *ip = (struct ip_udp_hdr *)pkt;

    /*

•    *      Construct an IP header.
  

•    *      Construct an IP header.
  

Don't change formatting in a functional patch.

     */
    /* IP_HDR_SIZE / 4 (not including UDP) */
    ip->ip_hl_v  = 0x45;
    ip->ip_tos   = 0;

•   ip->ip_len   = htons(IP_HDR_SIZE);
  

•   ip->ip_len   = htons(pkt_len);
  

It used to be pretty misleading that this function would set a value of this to include only the IP header, only to be overwritten later. This is way better.

    ip->ip_id    = htons(net_ip_id++);

•   ip->ip_off   = htons(IP_FLAGS_DFRAG);   /* Don't fragment */
  

•   ip->ip_off   = htons(IP_FLAGS_DFRAG);   /* Don't fragment */
  

Don't change formatting in a functional patch.

    ip->ip_ttl   = 255;

•   ip->ip_p     = prot;
    ip->ip_sum   = 0;
    /* already in network byte order */
    net_copy_ip((void *)&ip->ip_src, &source);
    /* already in network byte order */
    net_copy_ip((void *)&ip->ip_dst, &dest);
  

•   ip->ip_sum  = compute_ip_checksum(ip, IP_HDR_SIZE);
  

}

void net_set_udp_header(uchar *pkt, struct in_addr dest, int dport, int sport, @@ -1460,11 +1479,8 @@ void net_set_udp_header(uchar *pkt, struct in_addr dest, int dport, int sport, if (len & 1) pkt[IP_UDP_HDR_SIZE + len] = 0;

•   net_set_ip_header(pkt, dest, net_ip);
  

•   ip->ip_len   = htons(IP_UDP_HDR_SIZE + len);
  

•   ip->ip_p     = IPPROTO_UDP;
  

•   ip->ip_sum   = compute_ip_checksum(ip, IP_HDR_SIZE);
  

•   net_set_ip_header(pkt, dest, net_ip, IP_UDP_HDR_SIZE + len,
  

•                     IPPROTO_UDP);
    ip->udp_src  = htons(sport);
    ip->udp_dst  = htons(dport);
    ip->udp_len  = htons(UDP_HDR_SIZE + len);
  

diff --git a/net/ping.c b/net/ping.c index 9508cf1160..254b646193 100644 --- a/net/ping.c +++ b/net/ping.c @@ -20,16 +20,11 @@ struct in_addr net_ping_ip; static void set_icmp_header(uchar *pkt, struct in_addr dest) { /*

•    *      Construct an IP and ICMP header.
  

•    *      Construct an ICMP header.
     */
  

•   struct ip_hdr *ip = (struct ip_hdr *)pkt;
    struct icmp_hdr *icmp = (struct icmp_hdr *)(pkt + IP_HDR_SIZE);
  
  

•   net_set_ip_header(pkt, dest, net_ip);
  

•   ip->ip_len   = htons(IP_ICMP_HDR_SIZE);
  

•   ip->ip_p     = IPPROTO_ICMP;
  

•   ip->ip_sum   = compute_ip_checksum(ip, IP_HDR_SIZE);
  

•   net_set_ip_header(pkt, dest, net_ip, IP_ICMP_HDR_SIZE, IPPROTO_ICMP);
  
    icmp->type = ICMP_ECHO_REQUEST;
    icmp->code = 0;
  

-- 2.11.0

---

U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot