On Tue, Nov 05, 2024 at 06:03:44AM -0700, Simon Glass wrote:
Hi Tom,
On Mon, 4 Nov 2024 at 16:32, Tom Rini trini@konsulko.com wrote:
On Mon, Oct 28, 2024 at 05:31:30PM +0300, Mikhail Kshevetskiy wrote:
Legacy TCP stack is bad. Here are some of the known issues:
- tcp packet from other connection can break a current one
- tcp send sequence always starts from zero
- bad tcp options processing
- strange assumptions on packet size for selective acknowledge
- tcp interface assumes one of the two scenarios:
so it's not possible to upload large amount of data from the board to remote host.
- data downloading from remote host to a board
- request-response exchange with a small packets
- wget test generate bad tcp stream, test should fail but it passes instead
This series of patches fixes all of the above issues.
I know Peter asked on the last one, but I want to ask as well. With lwIP merged, why do we want to add features to the old stack? I can see fixing issues, but not adding new functionality as well. Thanks.
Let's apply this. It has tests and the old stack is still used by a lot of boards. At present lwip is only used on one. There is more work to do on the new stack, including finishing off the sandbox implementation.
Yes, I'm fine with the fixes, but I'm not sure why we want to add new features to the old stack.
We've had exactly zero releases with lwIP included, so counting the number of boards with it enabled is not helpful. I'm sure that once I merge the https support series a whole lot of platforms will switch because that's needed for easier SystemReady IR certification.