Re: [U-Boot] [U-Boot,RFC] common: cli_hush: avoid dead code

On Tue, Nov 24, 2015 at 04:54:21PM +0800, Peng Fan wrote:

Condition "(value == NULL && ++value == NULL)" actully will always return false.

Instead, use condition "(value == NULL || *(value + 1) == 0)" to detect such expression "c=". To "c=", *(value + 1) is 0, so directly return -1, but not continue.

Signed-off-by: Peng Fan Peng.Fan@freescale.com Cc: Rabin Vincent rabin@rab.in Cc: Simon Glass sjg@chromium.org Cc: Tom Rini trini@konsulko.com Reviewed-by: Simon Glass sjg@chromium.org

Applied to u-boot/master, thanks!