Hi Pali,
On 01.11.22 23:39, Pali Rohár wrote:
On Wednesday 07 September 2022 11:24:58 Pali Rohár wrote:
On Wednesday 17 August 2022 23:00:43 Pali Rohár wrote:
On Wednesday 17 August 2022 12:05:20 Stefan Roese wrote:
On 17.08.22 11:59, Pali Rohár wrote:
File name with pattern u-boot-spl* is used on all places except in kwb image for binary with SPL-only code. Combined binary with both SPL and proper U-Boot in other places has file name pattern u-boot-with-spl*.
Make it consistent also for kwb image and rename u-boot-spl.kwb to u-boot-with-spl.kwb as this image contains both SPL and proper U-Boot code.
Signed-off-by: Pali Rohár pali@kernel.org
This is just RFC patch, please let me know what do you think.
Frankly, I wondered a few days ago if this image only includes the SPL image. So this change makes total sense to me. It might break some out-of-tree building scripts, but I think we should go forward this way:
Reviewed-by: Stefan Roese sr@denx.de
Ok! If you like it, feel free to take it. First time I was also confused and having consistent naming could help other people too...
Btw, there is similar "rename" patch for u-boot-with-dtb.bin target: https://patchwork.ozlabs.org/project/uboot/patch/20220801154220.20068-2-pali...
Rename for u-boot-with-dtb.bin was accepted.
Thanks for the notice. I'm all for adding this kwb change as well. Could you please send a non-RFC patch for this which also renames all the "u-boot-spl.kwb" occurrences in the tree?
Thanks, Stefan