Kumar Gala writes:
Kumar> Yuli, I agree with only enabling ports that will be used. I Kumar> guess I would expect the port to be used in Linux.
If it's to be used in Linux but not in the U-Boot, let Linux initialise it.
Kumar> I'm working on an updated 2.6 SCC uart driver and realized Kumar> that I needed to enable the 2nd port in BCSR. I had expected Kumar> that u-boot would have already handled it.
I see. In Arabella Linux, there is clear separation between boot and kernel and between chip-specific and board-specific code. ADS-specific file in Linux kernel is the place where the BCSR handling lives, so we've got generic SCC UART driver and perform all the initialisations (including board-specific BCSR) only when some code requests them.
Kumar> Looking at the patch, I was wondering if there was any reason Kumar> to not enable both RS232 ports by default.
Yuli> Only the console port was enabled before the patch. Is there Yuli> any reason for the patch to change this behaviour? Also, I see Yuli> no reason to enable any peripheral which isn't going to be Yuli> used.