Re: [U-Boot] [PATCH 4/6] net: phy: bugfixes: mv88E61xx multichip addressing support

Dear Prafulla Wadaskar,

In message 1247758084-12296-4-git-send-email-prafulla@marvell.com you wrote:

With these fixes, this driver works properly for multi chip addressging mode

Bugfixes:

1. Build error fixed for function mv88e61xx_busychk_multic-fixed
2. PHY dev address error detection- fixed
3. wrong busy bit was refered in function mv88e61xx_busychk -fixed
4. invalid data read ptr was refered for RD_PHY in case of multichip addressing mode -fixed

The Multichip Address mode is tested with RD6281A board having MV88E6165 switch on it

Signed-off-by: Prafulla Wadaskar prafulla@marvell.com

drivers/net/phy/mv88e61xx.c | 18 +++++++++--------- drivers/net/phy/mv88e61xx.h | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-)

This patch causes compiler warnings:

mv88e61xx.c: In function 'mv88e61xx_busychk_multic': mv88e61xx.c:46: warning: passing argument 4 of 'miiphy_read' from incompatible pointer type mv88e61xx.c: In function 'mv88e61xx_wr_phy': mv88e61xx.c:61: warning: passing argument 4 of 'miiphy_read' from incompatible pointer type mv88e61xx.c:57: warning: unused variable 'reg' mv88e61xx.c: In function 'mv88e61xx_rd_phy': mv88e61xx.c:80: warning: passing argument 4 of 'miiphy_read' from incompatible pointer type mv88e61xx.c:76: warning: unused variable 'reg'

(when building for the rd6281a board using ELDK 4.2, i. e. gcc-4.2.2)

Also, the rd6281a board throws this warning:

nand_util.c:45:2: warning: #warning Please define CONFIG_SYS_64BIT_VSPRINTF for correct output!

Could you please provide fixes?

Thanks in advance.

Best regards,

Wolfgang Denk