Hi Simon,
On Tue, Apr 18, 2023 at 11:31 PM Simon Glass sjg@chromium.org wrote:
We don't need to commit the SPI-flash MTRR change immediately, since it is now done in the board_init_f_r(). Also this causes chromebook_link64 to hang.
Could you add more details as to why this causes chromebook_link64 to hang?
As I see the mtrr_commit() has been there since TPL was introduced on day 1, there must be some other places changes that caused the regression on chromebook_link64??
Drop the extra mtrr_commit() in the SPL implementation.
Signed-off-by: Simon Glass sjg@chromium.org
(no changes since v1)
arch/x86/lib/spl.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/arch/x86/lib/spl.c b/arch/x86/lib/spl.c index 388b51086410..f0b74d04252a 100644 --- a/arch/x86/lib/spl.c +++ b/arch/x86/lib/spl.c @@ -147,7 +147,6 @@ static int x86_spl_init(void) debug("%s: SPI cache setup failed (err=%d)\n", __func__, ret); return ret; }
mtrr_commit(true);# else ret = syscon_get_by_driver_data(X86_SYSCON_PUNIT, &punit); if (ret) --
Regards, Bin