Re: [U-Boot] [PATCH v2 3/8] cmd: bootimg: Add bootimg command

2 Dec 2019


      Hi Eugeniu,
On Wed, Nov 27, 2019 at 9:17 PM Eugeniu Rosca erosca@de.adit-jv.com wrote:
...
Hi Sam,
On Wed, Oct 23, 2019 at 05:34:22PM +0300, Sam Protsenko wrote:
...
+static int do_bootimg_get_dtb_file(cmd_tbl_t *cmdtp, int flag, int argc,

                           char * const argv[])


+{

char *endp;


char buf[65];


u32 index;


ulong addr;


u32 size;


if (argc < 3 || argc > 4)


        return CMD_RET_USAGE;


index = simple_strtoul(argv[1], &endp, 0);


if (*endp != '\0') {


        printf("Error: Wrong index\n");


        return CMD_RET_FAILURE;


}


if (!android_image_get_dtb_by_index(bootimg_addr(), index, &addr,


                                    &size))


As discussed in https://patchwork.ozlabs.org/patch/958594/#2302310, we
try to enhance the "dtimg" U-Boot command to be able to identify DT
blobs by "id" or "rev" [*] field value.
It's quite challenging in this context to avoid conflicting with your
recently proposed "bootimg" command, since the latter makes use of the
android_image_get_dtb_by_index API, which is subject of modification
and/or renaming.
I am willing to cooperate to entirely avoid or reconcile the conflict
in the best possible way, but for that I need your feedback.
I'd like this patch series to be applied ASAP (probably before DTBO
patches you mention are merged). It's been too long as it is. Once
merged and we are unblocked w.r.t. Android boot stuff, we can then
look into DTBO changes you mention, and if any C API are changed, we
can change those usage overall the U-Boot tree. Hope you agree. I will
help you guys to figure out all DTBO related changes further, but
please let's get this patch series over with...
Thanks!
...
[*] https://source.android.google.cn/devices/architecture/dto/partitions
--
Best Regards,
Eugeniu