15 Nov
2023
15 Nov
'23
11:38 p.m.
On Sat, Nov 11, 2023 at 05:09:12PM -0700, Simon Glass wrote:
Rather than passing it all the command-line args, pass in the pieces that it needs. These are the image address, the ramdisk address/name and the FDT address/name.
Ultimately this will allow usage of this function without being called from the command line.
OK, so this goal is good.
[snip]
return bootm_find_images(img_addr, argc > 1 ? argv[1] : NULL,argc > 2 ? argv[2] : NULL, 0, 0);
That we repeat this much harder to read test/if/else three times now is less good. Can we find some way to hide the complexity here in the case where it's coming from a command and so we have argc/argv[] ?
--
Tom