On 2015-01-11 11:30, Hans de Goede wrote:
Hi,
On 11-01-15 10:59, Ian Campbell wrote:
I've applied #1 and #3. I'd like to hear from Hans on the v0.2 stuff.
I've no real opinion on this, I do NOT like the introduction of a third version of the i2c / rsb and axp code (we already have both a u-boot and a kernel version to maintain of both).
I do not like this replication of logic very much as well. But already my attempts to put complete C modules in the monitor segment failed. And then, would we be able to still use those functions also from the rest of uboot?
What would be possible is to invoke SYSTEM_RESET from reset_cpu. Not much to gain, though, as only the sun7i has PSCI, and its logic is also used by 4i and 5i.
Given that and rumors I've heard of a new PSCI version which may make things like shutdown optional, I would prefer to wait for such a new PSCI version and jump directly to that.
How long may this take to materialize?
But ultimately I defer to Ian here, so Ian whatever you say goes :)
Regards,
Hans
Also, the other patches are touching generic arm code, so ought to be CC-d to (and perhaps go via) the core ARM maintainer (Albert Aribaud).
Will do if I get the OK sunxi-wise to proceed.
Jan
IMHO it would be better if the common code changes involved platform-selectable #ifdef's for enabling v0.1 and v0.2, to allow platforms to opt-in to v0.2 support.
On Wed, 2014-12-31 at 13:46 +0100, Jan Kiszka wrote:
This adds CPU offlining and PSCI v0.2 support. Changes since v2:
- add more comments to psci_fiq_enter (patch 1)
- rebase over u-boot-sunxi/next
See patches for further details.
Jan
Jan Kiszka (4): sun7i: Add support for taking CPUs offline via PSCI sun7i: Add PSCI v0.2 support sun7i: Move psci_arch_init close to text_end sun7i: Implement PSCI v0.2 AFFINITY_INFO
arch/arm/cpu/armv7/psci.S | 35 +++- arch/arm/cpu/armv7/sunxi/psci.S | 351 ++++++++++++++++++++++++++++++++-- arch/arm/cpu/armv7/virt-dt.c | 5 +- arch/arm/include/asm/arch-sunxi/cpu.h | 2 + arch/arm/include/asm/psci.h | 24 ++- 5 files changed, 392 insertions(+), 25 deletions(-)