Hi Poonam,
On Mon, Oct 22, 2018 at 11:43 AM Poonam Aggrwal poonam.aggrwal@nxp.com wrote:
-----Original Message----- From: Bin Meng [mailto:bmeng.cn@gmail.com] Sent: Monday, October 22, 2018 7:41 AM To: York Sun york.sun@nxp.com Cc: Poonam Aggrwal poonam.aggrwal@nxp.com; U-Boot Mailing List <u- boot@lists.denx.de> Subject: Re: [PATCH 1/2] powerpc: t1040: Correct RCW MAC2_GMII_SEL value
On Mon, Oct 15, 2018 at 1:21 PM Bin Meng bmeng.cn@gmail.com wrote:
On Mon, Oct 8, 2018 at 11:07 PM York Sun york.sun@nxp.com wrote:
On 10/08/2018 06:51 AM, Bin Meng wrote:
Per T1040RM (Rev. 1, 08/2015), the value of FSL_CORENET_RCWSR13_MAC2_GMII_SEL_ENET_PORT is wrong and
should be
0x00000080 (bit 440 in the RCW).
Signed-off-by: Bin Meng bmeng.cn@gmail.com
Poonam,
Please review and confirm on T1040. Thanks.
Ping ?
Ping ?
Apologies Bin, York for such late response.... The patch looks correct, the value of FSL_CORENET_RCWSR13_MAC2_GMII_SEL_ENET_PORT should be 0x80 indeed, I would suggest that I test it once that DTSEC2 RGMII works with this change, because I see more changes which could be required in drivers/fm/t1040.c...seems a goof up there as well.
t1040.c changes is patch [2/2], see https://lists.denx.de/pipermail/u-boot/2018-October/343499.html
Regards, Bin