Hi,
On 26 May 2018 at 05:04, Eugeniu Rosca roscaeugeniu@gmail.com wrote:
Hi Simon,
On Fri, May 25, 2018 at 08:07:37PM -0600, Simon Glass wrote:
Hi,
On 24 May 2018 at 16:04, Eugeniu Rosca roscaeugeniu@gmail.com wrote:
Besides the above, it is not clear to me if your Reviewed-by applies to to this patch partially (since you expressed some concerns) or applies globally, in which case the concerns are not major?
It means that I've reviewed the patch and I'd like some changes, but don't want to review it after you have made those changes, so you should add the Reviewed-by tag when doing the next version.
But in this case your change is correct, so please don't worry. It's unfortunate that the uclass name needs a hypen, but I understand why.
Thanks for shedding light both on technical aspects and the review process itself, which is very helpful.
Regarding the state of the whole patch-set, I think we reached a point in which all the review comments have been handled. Please, let me know if you still see any open topics. Otherwise, I will be waiting for Tom's feedback and if it doesn't come in the next 1-2 weeks, I will send a friendly reminder.
Sounds good, I don't have anything else.
Regards, Simon