
Hi Mugunthan,
On 2 March 2016 at 22:06, Mugunthan V N mugunthanvnm@ti.com wrote:
When a platform is converted to support DM and when its scsi driver is not converted to support DM, there is a build break as multiple definition of scsi_init(). So select CONFIG_DISK only when the platform supports CONFIG_DISK.
drivers/built-in.o: In function `scsi_init': /home/mugunthan/workspace/git/work/u-boot/dm-sata/drivers/block/disk-uclass.c:37: multiple definition of `scsi_init' board/sunxi/built-in.o:/home/mugunthan/workspace/git/work/u-boot/dm-sata/board/sunxi/ahci.c:74: first defined here Makefile:1171: recipe for target 'u-boot' failed make: *** [u-boot] Error 1
Signed-off-by: Mugunthan V N mugunthanvnm@ti.com
drivers/block/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
This is because you are defining scsi_init() in the uclass, but I don't think that is a great idea. Or at least it should only be defined if DISK is enabled.
Regards, Simon