On Wed, Jun 20, 2018 at 07:28:15AM +0000, Joakim Tjernlund wrote:
On Tue, 2018-06-19 at 23:57 -0400, Tom Rini wrote:
With the move to using at least gcc-6 for many targets we now have C code that requires the GNU11 C standard to be used in all cases.
Requiring gcc-6 is a bit much I think, there are lots of cross gcc's out there that is older. I don't think even the kernel needs gcc-6
We've required gcc-6 for ARM since v2018.01, and we were warning about that for a while longer than that, due to toolchain issues.
That said, my commit message is clearly not clear enough. We don't require gcc-6 for everyone, we require support for -std=gnu11, and that goes back a long ways. It's just that since some platforms require gcc-6 we've started having (and this is good, the code is cleaner!) some C-11'isms sneak into the code. For example, sandbox now fails to compile on older hosts due to a for (int i = 0; ...) in cmd/iotrace.c