Hi,
On Thu, 29 Oct 2020 at 10:15, Tom Rini trini@konsulko.com wrote:
On Thu, Oct 29, 2020 at 01:11:15PM -0300, Walter Lozano wrote:
On 29/10/20 12:19, Tom Rini wrote:
On Thu, Oct 29, 2020 at 07:14:55AM +0200, Baruch Siach wrote:
Hi Simon,
Adding Walter to Cc.
On Thu, Oct 29 2020, Simon Glass wrote:
This feature is incompatble with of-platdata since it uses the U_BOOT_DEVICE() macro. With of-platdata the only devices permitted are those created by dtoc.
Drop this option for now, until the driver can be corrected.
As I understand, of-platdata is only enabled in SPL. Is there a way to limit imx_thermal drop to SPL? The thermal driver in not very useful in SPL anyway, right?
As you pointed of-platdata is intended for TPL/SPL to avoid the overhead of DTB and libraries. If this option is enabled and the driver does not support it, the device won't be created in TPL/SPL but is should on U-Boot. In order to limit the drop to SPL can CONFIG_SPL_BUILD be used?
Regarding the usefulness of im_thermal in SPL I can't comment.
Well, sigh, step one is to finish the migration to Kconfig for IMX_THERMAL as it has a symbol, but it's still set in a ton of board config files. We only build thermal in SPL when SPL_THERMAL is set, so I assume this is about trying to use of-platdata in U-Boot proper too, to keep / further reduce the size of U-Boot itself to stay within size limits.
Well, I suspect maybe part of the problem is that since the symbol isn't migrated properly, it's not being not built when we don't need it. I did the migration and queued up a build, I should have some answers later today.
In the meantime I'll send a v2 patch which just disables the driver in SPL.
Regards, Simon