Re: [U-Boot-Users] [PATCH] SPI Flash: Support the ST Microelectronics M25P80 and M25P40 SPI Flash

In message 20080610024534.77FA14813D@mcmullan-linux.hq.netapp.com you wrote:

This commit adds MTD support for the M25P80 (1Mx8) and the M25P40 (512kx8) SPI Flash components from ST Microelectronics.

...

--- /dev/null +++ b/drivers/mtd/spi/stmicro.c @@ -0,0 +1,326 @@ +/*

• • $Id$

Please remove these two lines.

• do {

• ret = spi_xfer(spi, 8, NULL, &status, 0);
  

• if (ret)
  

• 	return -1;
  

• if ((status & STMICRO_SR_WIP) == 0)
  

• 	break;
  

• } while (1 || get_timer(timebase) < timeout);

Hm... the timeout code seems to be disabled here?

I think you should remove either the first or the second expression.

Best regards,

Wolfgang Denk