-----Original Message----- From: Ben Warren [mailto:biggerbadderben@gmail.com] Sent: Monday, July 12, 2010 11:54 AM To: Prafulla Wadaskar Cc: Albert Aribaud; u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH V3 2/5] mv_egiga: support SoCs other than kirkwood
On 7/11/2010 10:45 PM, Prafulla Wadaskar wrote:
-----Original Message----- From: u-boot-bounces@lists.denx.de [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Albert Aribaud Sent: Sunday, July 11, 2010 1:32 PM To: u-boot@lists.denx.de Subject: [U-Boot] [PATCH V3 2/5] mv_egiga: support SoCs other than kirkwood
...snip...
struct eth_device *dev = eth_get_dev_by_name(devname);
- struct kwgbe_device *dkwgbe = to_dkwgbe(dev);
- struct kwgbe_registers *regs = dkwgbe->regs;
- struct mv_egiga_device *dmvegiga = to_mv_egiga(dev);
- struct mv_egiga_registers *regs = dmvegiga->regs;
I suggest to keep name as mvgbe here instead of mv_egiga, 3
additional chars, increases overall code size huh? The name is consistent with the rest of his work, and *if* the code really increases in size, I can't imagine that 3 chars really matters...
That's true. But if we can do it why to avoid it? again it helps to keep same indentation (keeping them below 80char size)
Regards.. Prafulla . .