On Sun, Aug 20, 2023 at 10:03:18PM +0000, Jonas Karlman wrote:
Nodes with bootph-pre-sram/ram props are bound in multiple phases:
- At TPL (bootph-pre-sram) or SPL (bootph-pre-ram) phase
- At U-Boot proper pre-relocation phase
- At U-Boot proper normal phase
However the binding and U-Boot Driver Model documentation indicate that only nodes marked with bootph-all or bootph-some-ram should be bound in the U-Boot proper pre-relocation phase.
Change ofnode_pre_reloc to report a node with bootph-pre-ram/sram prop with a pre-reloc status only after U-Boot proper pre-relocation phase. Also update the ofnode_pre_reloc documentation to closer reflect the binding and driver model documentation.
This changes behavior of what nodes are bound in the U-Boot proper pre-relocation phase. Change to bootph-all or add bootph-some-ram prop to restore prior behavior.
Signed-off-by: Jonas Karlman jonas@kwiboo.se Reviewed-by: Simon Glass sjg@chromium.org Signed-off-by: Jonas Karlman jonas@kwiboo.se Reviewed-by: Simon Glass sjg@chromium.org
I'm following up here now that this is committed because there's been a large number of commits to update dts files because of the change this commit makes. And I know there's other platforms still broken that need the same update. And it seems the change is almos always to mark more (or all!) nodes as bootph-all. So, is this patch really correct, and really what we want to be doing here? I was not expecting this much fallout when I saw this come in. Thanks.