Hello Takahiro-san,
From: U-Boot u-boot-bounces@lists.denx.de on behalf of Simon Glass sjg@chromium.org Sent: Thursday, July 27, 2023 2:50 AM
On Wed, 26 Jul 2023 at 02:38, AKASHI Takahiro takahiro.akashi@linaro.org wrote:
The commit 85dc58289238 ("firmware: scmi: prepare uclass to pass channel reference") added an explicit parameter, channel, but it seems to make the code complex.
Hiding this parameter will allow for adding a generic (protocol-agnostic) helper function, i.e. for PROTOCOL_VERSION, in a later patch.
Signed-off-by: AKASHI Takahiro takahiro.akashi@linaro.org
v2
- new patch
drivers/clk/clk_scmi.c | 27 ++------- drivers/firmware/scmi/scmi_agent-uclass.c | 74 ++++++++++++++++++----- drivers/power/regulator/scmi_regulator.c | 27 +++------ drivers/reset/reset-scmi.c | 19 +----- include/scmi_agent.h | 15 +++-- 5 files changed, 86 insertions(+), 76 deletions(-)
Reviewed-by: Simon Glass sjg@chromium.org
Sorry for this late feedback. I initially saw no issues with this patch series but testing the series against stm32mp135f-dk board which is using SCMI resources, I saw the board failed to boot. The issue is related to udevice parent tree and common clock framework. I'll post comments on patch 01/12.
Best regards, Etienne