Re: [PATCH u-boot] ata: Fix dependency for CONFIG_SATA_SIL

On 12/29/22 18:15, Pali Rohár wrote:

sata_sil.c is PCI driver and without CONFIG_PCI is building of U-Boot failing:

   LD      u-boot
 ld.bfd: drivers/ata/sata_sil.o: in function `sil_exec_cmd':
 drivers/ata/sata_sil.c:148: undefined reference to `dm_pci_phys_to_bus'
 ld.bfd: drivers/ata/sata_sil.o: in function `sil_pci_probe':
 drivers/ata/sata_sil.c:687: undefined reference to `dm_pci_get_bdf'
 ld.bfd: drivers/ata/sata_sil.c:691: undefined reference to `dm_pci_read_config16'
 ld.bfd: drivers/ata/sata_sil.c:701: undefined reference to `dm_pci_map_bar'
 ld.bfd: drivers/ata/sata_sil.c:704: undefined reference to `dm_pci_map_bar'
 ld.bfd: drivers/ata/sata_sil.c:713: undefined reference to `dm_pci_write_config16'
 ld.bfd: drivers/ata/sata_sil.c:717: undefined reference to `dm_pci_read_config16'
 ld.bfd: drivers/ata/sata_sil.o: in function `sil_cmd_identify_device':
 drivers/ata/sata_sil.c:256: undefined reference to `dm_pci_phys_to_bus'
 ld.bfd: drivers/ata/sata_sil.o: in function `sil_sata_rw_cmd':
 drivers/ata/sata_sil.c:330: undefined reference to `dm_pci_phys_to_bus'
 ld.bfd: drivers/ata/sata_sil.o: in function `sil_sata_rw_cmd_ext':
 drivers/ata/sata_sil.c:377: undefined reference to `dm_pci_phys_to_bus'
 make: *** [Makefile:1778: u-boot] Error 1

Signed-off-by: Pali Rohár pali@kernel.org

Reviewed-by: Stefan Roese sr@denx.de

Thanks, Stefan

---

drivers/ata/Kconfig | 1 + 1 file changed, 1 insertion(+)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig index a063b221cd1f..3fe53d6d4f3a 100644 --- a/drivers/ata/Kconfig +++ b/drivers/ata/Kconfig @@ -135,6 +135,7 @@ config SATA_MV

config SATA_SIL bool "Enable Silicon Image SIL3131 / SIL3132 / SIL3124 SATA driver support"

• depends on PCI select AHCI select LIBATA help

Viele Grüße, Stefan Roese