On Mon, 16 Feb 2009, Wolfgang Denk wrote:
Dear ksi@koi8.net,
In message Pine.LNX.4.64ksi.0902131156250.26866@home-gw.koi8.net you wrote:
Can you please send your patches with some better commit messages. You only send your Signed-off-by, without any explanation. Please change this.
There is not much sense in extensive commit messages in this case, IMHO. It is not a bug fix or added feature at one particular place; it is a major rework. The only message I can give is something like "Changes for multiadapter/multibus I2C support..."
This sounds very much as if there was a danger that the patches are not logically cut - did you make sure that eahc of the commits is still bisectable?
I will rebase them and slice 'em in smaller pieces.
Unfortunately this is a major rework so there is no way one can make small patches really independent. Changes to include/i2c.h, e.g. make the entire old code uncompilable so they only make sence together with some other parts that constitute the core of the new code. Everything else is much easier when the core is in.
--- ****************************************************************** * KSI@home KOI8 Net < > The impossible we do immediately. * * Las Vegas NV, USA < > Miracles require 24-hour notice. * ******************************************************************