Hi Hans,
On 12 May 2015 at 09:15, Hans de Goede hdegoede@redhat.com wrote:
Hi,
On 05/12/2015 03:39 PM, Prof. Dr. Gundolf Kiefer wrote:
Dear developers,
the attached patch adds LED support for the Cubietruck board.
I found that the support for the onboard leds is missing for sunxi-based boards in the latest Debian unstable and perhaps upstream version of U-Boot. IMHO LEDs are very helpful for headless systems. Perhaps the patch can be helpful somehow.
The code has basically been ported from the U-Boot version maintained at linux-sunxi.org. As in the sunxi version, the blue led is switched on by default.
Kind regards,
Gundolf Kiefer
Thanks for the patch, but we really do not want to add new options to CONFIG_SYS_EXTRA_OPTIONS, at a minimum you need to add new Kconfig options for the leds, using gpio names for them, and sunxi_name_to_gpio in some place to translate to gpio numbers.
But we really do not want that either for upstream u-boot master we've switched to using devicetree for all sunxi boards, and we really want to use devicetree for this, which already has the led info, rather then duplicating the led info in sunxi defconfig files.
Simon, do we already have support for gpio-leds through devicetree in the device-model code somewhere?
No there is no driver at present. But given that we have gpio_request_by_name() this should be pretty simple to implement (i.e. the GPIO binding is already supported). I'm happy to help with pointers/advice if you like.
Regards, Simon
Regards,
Hans
Begin forwarded message:
Date: Tue, 05 May 2015 09:46:39 -0700 From: Vagrant Cascadian vagrant@aikidev.net To: "Prof. Dr. Gundolf Kiefer" gundolf.kiefer@hs-augsburg.de, 783846@bugs.debian.org Subject: Re: Bug#783846: Patch to enable LEDs on sunix/Cubietruck
On 2015-04-30, Prof. Dr. Gundolf Kiefer wrote:
It seems that the support for the onboard leds is missing for sunxi-based boards even in the latest version (Debian unstable). IMHO LEDs are very helpful for headless systems.
Thanks for the patches!
If you could submit these patches to u-boot upstream, that would be best; we're trying to minimize the patches that are not already included upstream.
live well, vagrant
Prof. Dr. Gundolf Kiefer Effiziente Eingebettete Systeme - Efficient Embedded Systems Fakultät für Informatik - Faculty of Computer Science Hochschule Augsburg - University of Applied Sciences http://www.hs-augsburg.de/~kiefer