Hello!
On Sunday 17 January 2021 16:07:30 Lokesh Vutla wrote:
Hi Lukasz,
On 29/11/20 10:16 pm, Pali Rohár wrote:
This patch series fix usbtty code (serial console via USB peripheral mode), fix underlying musb peripheral code, fix compilation of CONFIG_USB_DEVICE (used by usbtty), remove unused Nokia RX-51 code to decrease size of U-Boot binary and finally enable usbtty serial console for Nokia RX-51.
With this patch series debugging of Nokia RX-51 can be done also via USB serial console.
On computer this serial console is accessible via /dev/ttyACM0 device.
With current implementation there is an issue in musb driver that it loose receiving bytes from USB bus when too many a characters are send over USB tty from computer. Typing on keyboard to kermit terminal connected to /dev/ttyACM0 is working fine. But pasting more more bytes to terminal cause data lost on receiving side. I do not know where is the issue or how to fix it (it looks like that data are lost at low level when reading them from msub FIFO hardware) but typing on keyboard is working fine. This is rather issue for sending files via x/y/z-modem or kermit protocol. Currently U-Boot is not able to receive any file via usbtty with musb driver due to this issue.
Can you take a look at usb related patches and merge them if you are okay with it?
Thanks and regards, Lokesh
I would like to remind this patch series too!
I have not received any negative feedback on it for 2 months and patches were already reviewed by Pavel.
Could you please merge this patch series?
Pali Rohár (13): serial: usbtty: Fix puts function usb: musb: Fix compilation of gadget code usb: musb: Always clear the data toggle bit when configuring ep usb: musb: Fix configuring FIFO for endpoints usb: musb: Read value of PERI_RXCSR to 16bit variable usb: musb: Fix transmission of bigger buffers usb: gadget: Do not export usbd_device_* arrays usb: gadget: Use dbg_ep0() macro instead of serial_printf() arm: omap3: Compile lowlevel_init() function only when it is used arm: omap3: Compile s_init() function only when it is used Nokia RX-51: Remove function set_muxconf_regs() Nokia RX-51: Move content of rx51.h to rx51.c Nokia RX-51: Enable usbtty serial console by default
Makefile | 1 + arch/arm/mach-omap2/omap3/board.c | 3 + arch/arm/mach-omap2/omap3/lowlevel_init.S | 6 +- board/nokia/rx51/rx51.c | 28 +- board/nokia/rx51/rx51.h | 377 ---------------------- configs/nokia_rx51_defconfig | 6 +- doc/README.nokia_rx51 | 15 +- drivers/serial/usbtty.c | 4 +- drivers/usb/gadget/core.c | 38 +-- drivers/usb/gadget/ep0.c | 47 ++- drivers/usb/musb/musb_core.c | 10 +- drivers/usb/musb/musb_udc.c | 19 +- include/configs/nokia_rx51.h | 16 +- include/usbdevice.h | 15 - 14 files changed, 92 insertions(+), 493 deletions(-) delete mode 100644 board/nokia/rx51/rx51.h