Hi,
On 3/29/19 6:17 PM, Jonas Mark (BT-FIR/ENG1) wrote:
Gentle ping^2. Ready to apply?
I was kindof hoping on some follow up on concerns raised during v3, see below.
On 2/8/19 2:21 PM, Tomas Melin wrote:
- node_offset = fit_image_get_node(fit_header, location->name); + /* Get the splash image node */ + splash_file = env_get("splashfile"); + if (!splash_file) + splash_file = SPLASH_SOURCE_DEFAULT_FILE_NAME;
As mentioned during latest review round, this default name should really IMO be something else than a file name since it's not a file, it's a FIT node. splash_file should also probably be splash_node or so.
I'm not even sure is this patch really needed, selecting an appropriate name for the splash_location.name, matching the splash image node should work equally.
BR,
Tomas