On 14-01-29 02:32 PM, Tom Rini wrote:
On Mon, Jan 27, 2014 at 10:53:24AM -0800, Darwin Rambo wrote:
This patchset introduces the Broadcom bcm281xx family of mobile SoC chips. Broadcom kona hardware blocks are often found in Broadcom mobile SoC chips including the bcm281xx family, so support for some of these kona blocks is also provided here. These patches work on u-boot master as well as the u-boot-arm custodian tree.
Darwin Rambo (6): arch: kona: Initial commit of kona-common architecture code arch: bcm281xx: Initial commit of bcm281xx architecture code gpio: kona: Add Kona gpio driver i2c: kona: Add Kona I2C driver mmc: kona: Add Kona mmc driver board: bcm28155_ap: Add board files
Thanks for posting. Globally, please don't introduce another style for the file header, /*
- This works
- just fine.
- Including what the file is about
*/
OK - legacy stuff will be fixed.
And I also see the incorrect style sprinkled throughout.
I saw some '#define<tab>' mixed in with '#define<space>', and some other things I'd have sworn checkpatch complains about, so please make sure things are checkpatch clean (except for very long printed strings, which are an exception to line length rules).
Well, checkpatch was clean, so I think there's a problem with the tool. Another minor gripe is that checkpatch and "indent -linux" don't agree on everything, "int * foo" being one of them. :)
Finally, please CC the custodians for i2c/mmc for those drivers as they may have further comments than the above list.
OK. There are mmc, i2c and gpio drivers. I assume each driver gets a different CC:?
Thanks!
Thanks to you too!