On Fri, 2014-03-14 at 10:16 -0400, Tom Rini wrote:
On Fri, Mar 14, 2014 at 10:33:32AM +0000, Ian Campbell wrote:
Hi,
This is my first cut at an upstreamable series based upon the https://github.com/linux-sunxi/u-boot-sunxi.git#sunxi tree. The intention is to present a minimal starting point for upstreaming to which support for other processors, peripherals, boards etc can be added in the future. Therefore this has been stripped right back and currently supports only sun7i processors and the cubietruck board. Supported peripherals are UART, MMC and Ethernet.
Some global comments:
- If you haven't already, make sure it's all checkpatch clean.
I hadn't realised u-boot had a checkpatch. I shall do this.
- Use the SPDX tags rather than including the GPL boilerplate.
Agreed, I already sent out a patch to sunxi.git to make this happen there so I could sync it to this tree (so sunxi guys consider this a ping on 1394161088-9835-1-git-send-email-ijc@hellion.org.uk ;-))
I suppose I don't need to wait, but it was convenient to have a diff which always shrank...
- Please re-word the commit messages. The "how we got here / where this is from" is fine for the cover letter.
OK, that was mostly for my own reference. Mind if I put it at the end after "---" so git am will strip it?
- Magic numbers need to be defined.
Will do.
Thanks, Ian.