
10 Sep
2010
10 Sep
'10
6:32 p.m.
On Fri, 10 Sep 2010 10:35:04 -0400 Ben Gardiner bengardiner@nanometrics.ca wrote:
It's fine by me but I'm curious: why move the declaration of the stack variables i and net_size to before the check of the block_isbad function pointer?
U-Boot coding style prohibits mid-block declarations.
Before this change, I think there would be no allocation of these variables on the stack if the block_isbad function pointer is null.
The change should not make any difference in the generated code. The compiler is not going to delay its creation of the stack frame just because of where the variables are declared.
-Scott