2 May
2015
2 May
'15
4:04 p.m.
On Sat, 2015-05-02 at 15:03 +0100, Ian Campbell wrote:
I see I missed v2, oh well, this bit of code looks the same AFAICT.
On Thu, 2015-04-30 at 16:35 +0200, Hans de Goede wrote:
- if (hccr == (void *)SUNXI_USB1_BASE) {
priv->ahb_gate_mask = 1 << AHB_GATE_OFFSET_USB_EHCI0;priv->phy_index = 1;Inferring these from the base address is a bit unfortunate, should we not get told this by the DT, or from something higher up?
I have a feeling the answer will be "this can go away when X, Y & X have happened", in which case perhaps a comment to that affect?
BTW I ignored patches 1..7 based on the diffstats, please let me know if I should take a look for some reason.
Ian.