On 2/2/20 6:23 PM, Sean Anderson wrote:
On 2/2/20 12:15 PM, Marek Vasut wrote:
On 2/2/20 6:10 PM, Sean Anderson wrote:
Currently this is set from headers. No board has this set by default
Please check where socfpga_common.h and socfpga_soc64_common.h are included. This should then make it clear that this statement in not true.
, so we
don't need to modify any configs.
CONFIG_DESIGNWARE_WATCHDOG is only defined if CONFIG_HW_WATCHDOG is defined, and this is never defined in headers (or in the defconfigs).
This is what I see in socfpga_soc64_common.h on u-boot/master: 153 #ifdef CONFIG_SPL_BUILD 154 #define CONFIG_HW_WATCHDOG
The patch is wrong, see above. Also, it's missing a SoB line.
Ah, I just noticed that, thanks for pointing that out.
Note that I updated u-boot-socfpga/master and sent a PR just now (thanks for reminding me of that), it contains the DW WDT patches that were posted to the ML some time ago. You want to rebase the series on top of that.