Hi,
On 02-09-16 10:29, Chen-Yu Tsai wrote:
The sun8i-emac driver follows an old version of the proposed DT bindings, where the EMAC clock and EPHY control register range is listed directly, rather than through a syscon phandle.
Add back the syscon register range to avoid an invalid data access. We should fix the driver once the Linux kernel bindings have been finalized.
Signed-off-by: Chen-Yu Tsai wens@csie.org
Thanks, applied to my local tree and this will be part of the v2016.09 pullreq I plan to send out later today.
Regards,
Hans
arch/arm/dts/sun8i-h3.dtsi | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm/dts/sun8i-h3.dtsi b/arch/arm/dts/sun8i-h3.dtsi index 6babaf37177f..afa60793a235 100644 --- a/arch/arm/dts/sun8i-h3.dtsi +++ b/arch/arm/dts/sun8i-h3.dtsi @@ -466,9 +466,8 @@
emac: ethernet@1c30000 { compatible = "allwinner,sun8i-h3-emac";
syscon = <&syscon>;reg = <0x01c30000 0x104>;reg-names = "emac";
reg = <0x01c30000 0x104>, <0x01c00030 0x4>;reg-names = "emac", "syscon"; interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>; resets = <&ccu RST_BUS_EMAC>, <&ccu RST_BUS_EPHY>; reset-names = "ahb", "ephy";