Re: [U-Boot] [PATCH v2] armv8/ls2080a: configure PMU's PCTBENR to enable WDT

15 Apr 2016


      Hi Stuart,
Thanks for your suggestions about the patch, I will update it in v3 version.
Thanks
Yunhui
-----Original Message-----
From: Stuart Yoder 
Sent: Friday, April 15, 2016 10:16 AM
To: Yunhui Cui
Cc: york sun; u-boot@lists.denx.de
Subject: RE: [U-Boot] [PATCH v2] armv8/ls2080a: configure PMU's PCTBENR to enable WDT
...
-----Original Message-----
From: Yunhui Cui
Sent: Thursday, April 14, 2016 8:47 PM
To: Stuart Yoder stuart.yoder@nxp.com
Cc: york sun york.sun@nxp.com; u-boot@lists.denx.de
Subject: RE: [U-Boot] [PATCH v2] armv8/ls2080a: configure PMU's PCTBENR to enable WDT
Hi Stuart,
Yunhui, I thought that York recently sent patches to get rid of CONFIG_LS2085A.
[Yunhui] Only need add  #if defined(CONFIG_LS2080A) ?
Right.
...
I think this is getting too specific and adds unnecessary details.
What if we have A72 cores? ...as we will soon.  What about other SoCs? Just say:
/*
    * In certain Layerscape SoCs, the clock for each core's watchdog
    * has an enable bit in the PMU Physical Core Time Base Enable Register
    * PCTBENR), which allows the watchdog to operate.
Looks like I missed an openening parenthesis in my suggestion.
Thanks,
Stuart