Dear Wolfgang Denk,
On Sun, Oct 16, 2011 at 1:53 PM, Wolfgang Denk wd@denx.de wrote:
Dear Vadim Bendebury,
In message CANy1buJ0mhpDY948c+PM6u4EsWtoHw3+-u+m_FNiG3BztBinVA@mail.gmail.com you wrote:
because this chip is sensitive to the access cycle size (byte versus word).
When using macros one can rely on the passed in pointer type to decide which access to use (byte vs word). If using inline functions, there would be two separate functions required for read (byte and u32) and write (byte and u32).
This would then be an improvement in the code, as we then can see what the code is actually doing.
please see the latest patch (v5) which addresses the chip representation and register access wrapper comments.
cheers, /vb
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de What the gods would destroy they first submit to an IEEE standards committee.