On 08/04/2010 12:29 AM, Xiangfu Liu wrote:
On 08/03/2010 07:36 PM, Shinya Kuribayashi wrote:
Aconfccording to MAKEALL script, pb1000_ig is only used in Little- endian, so its default endian should be set to LE as well. I too missed this point in my previous patch.
thanks.
You still forgot to fix this part:
| No greetings in the longlog, please. Such comments, supplements are | to go below the three-dashes (---):
In other words, please remove "Hi Wolfgang" line, and in this case "v1:" and "v2:" at the same time. The resulting longlog would be like this:
<longlog>
From the document, if set all arguments in "OUTPUT_FORMAT"
to "tradbigmips", then even add "-EL" to gcc we still get EB format.
pb1x00 is only used in Little-endian, so its default endian should be set to LE as well
Signed-off-by: Xiangfu Liu xiangfu@openmobilefree.net Acked-by: Shinya Kuribayashi skuribay@pobox.com </longlog> ---
Hi Wolfgang, ....
v1: ...
v2: ...
board/dbau1x00/u-boot.lds | 2 +- board/gth2/u-boot.lds | 2 +- board/incaip/u-boot.lds | 2 +- board/pb1x00/u-boot.lds | 2 +- board/purple/u-boot.lds | 2 +- board/qemu-mips/u-boot.lds | 2 +- examples/standalone/mips.lds | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-)
: :
_
I recommend you to read the patch submission guide first. http://www.denx.de/wiki/U-Boot/Patches
With fixing above nits, feel free to add:
Acked-by: Shinya Kuribayashiskuribay@pobox.com
(by the way. I manually added this line to email. is the another way to add "Acked-by" like "Signed-off-by" is "-s")
Git doesn't support such feature itself, so edit commitlog manually. As an alternative, StackedGit can append those tags by "stg refresh --sign/--ack". Just for your information.