Re: [PATCH] i2c: ast_i2c: Remove SCL direct drive mode

Hello Eddie,

On 11.05.22 22:52, Eddie James wrote:

SCL direct drive mode prevents communication with devices that do clock stretching, so disable. The Linux driver doesn't use this mode, and the engine can handle clock stretching.

My first thought was why not make this option configurable, as I do not know if there is any user of this mode configuration.

But as linux does not use this option, we may can disable it.

Signed-off-by: Eddie James eajames@linux.ibm.com

drivers/i2c/ast_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Heiko Schocher hs@denx.de

It would be good to have here more comments from users of this driver.

bye, Heiko