Guennadi Liakhovetski schrieb:
On Tue, 29 Apr 2008, Jens Gehrlein wrote:
Hi Ben, Magnus,
here is my patch to enable 2x16 bit accesses to the LAN9x1x. I still not have a HW, so may I ask you to test it and, if applicable, fix the code?
Best Regards, Jens
drivers/net/smc911x.c | 17 ++++++++++++++++- 1 files changed, 16 insertions(+), 1 deletions(-)
diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c index d22c889..841a64d 100644 --- a/drivers/net/smc911x.c +++ b/drivers/net/smc911x.c @@ -30,6 +30,8 @@ #include <net.h> #include <miiphy.h>
+#define CONFIG_DRIVER_SMC911X_16_BIT 1
Looks like an obvious thing - you'll remove this define from the patch for final submission, right?
Oh, ah. You're right. I inserted this to do a compile test and to inspect the generated assembler code. This define should be later moved to the board specific header file.
Sorry.
Well spotted. Thank you.
Magnus, are you going to fix the code as proposed by Ben and Guennadi or should I resubmit the patch?
Best Regards, Jens